View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0022492 | mantisbt | ui | public | 2017-03-07 12:36 | 2017-10-08 23:52 |
Reporter | Kunda | Assigned To | community | ||
Priority | high | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 2.2.0 | ||||
Target Version | 2.7.0 | Fixed in Version | 2.7.0 | ||
Summary | 0022492: Regression: Resolved/Closed issues are not shown with a line-through (strike-through) | ||||
Description | 0017920 is a closed issue and should be shown with a strike-through. | ||||
Steps To Reproduce | I discovered this through a downstream issue: https://freecadweb.org/tracker/view.php?id=2949 | ||||
Tags | No tags attached. | ||||
Resolved/Closed Issues are not striked-through in 2.x. This has been the case as far back as it goes (even in the early development versions of the modern-ui branch prior to 2.0.0-beta.1). I didn't really pay attention to that until you mentioned it, but personally think it is a useful feature to visually indicate that an issue is closed, without having to hover with the mouse (the pop-up text does gives the status), so I would consider this a regression from 1.x that should be addressed. I'm not really sure if this was by design, or just an overlooked side effect of migrating to the new UI; @syncguru or @vboctor, please comment. |
|
If it was by design, wouldn't have it been mentioned somewhere like in a changelog or ticket ? |
|
In an ideal world yes, but I'm afraid you're presuming too much of our development process ;) |
|
Well it's as easy as adding this to the CSS for it to work again: .resolved { |
|
I know, but still I'd like to get the guys' input since I don't know if they removed it intentionally or not. |
|
Not sure if you are aware that there is at least one place where we still strike through, it's the Roadmap Striked through text is hard to read, maybe we should use it just for issue id links, but not for any description. |
|
This is a different case though - this is handled through custom functions, and not even with CSS [1]. |
|
Another one and the same approach 2. |
|
FYI, we're going to implement the temp CSS fix (0022492:0055991) on the FreeCAD tracker until you guys decide how to tackle this issue. I'm stating that here so it causes no confusion when looking at the downstream bug and it looks 'Fixed' when it's not. Cheers and thanks for your efforts, MantisBT 2.x is a great achievement. |
|
@atol personally the strikethrough doesn't make it difficult for me to read the roadmap. Maybe a way to deal with this is to add a mouse hover effect that would remove the strikethrough effect when hovering over the text ? |
|
Does not work that well if you print the roadmap ;-) To repeat what @dregad wrote: |
|
I'm personally not aware of this change being intentional. I agree with @atrol that we shouldn't strike through issue titles, but just issue ids. @syncguru did you drop this intentionally? |
|
It would be interesting to have a configuration parameter to decide if you want strike-through text for Closed tickets on the Roadmap page. Take in consideration the possibility of add a setting for that. It's not the first time users suggest a setting option. For example: 0011721 |
|
I agree with @didaquis I don't mind the strike through on the roadmap page and you could make it disappear if you hover the mouse over it. As for this ticket even though this is low priority it looks like a regression so please consider fixing. |
|
Why does this not have a target version? |
|
Temp fix is: |
|
I meant that 0022492:0057338 is a temporary workaround fix till the mantisbt folks decide how they want to proceed 0011721 |
|
Soft bump, wondering if the team has figured out this trivial issue yet? |
|
I don't believe this was intentional. I don't have a strong opinion either way. |
|