View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0026142 | mantisbt | plug-ins | public | 2019-09-15 14:42 | 2023-04-16 08:02 |
Reporter | dregad | Assigned To | dregad | ||
Priority | normal | Severity | feature | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Target Version | 2.25.0 | Fixed in Version | 2.25.0 | ||
Summary | 0026142: Improve handling of invalid / incorrectly installed plugins | ||||
Description | When installing plugins in a MantisBT instance, or when moving / upgrading MantisBT there are several things that can go wrong
Currently, some of these scenarios are not detected by Core, making it difficult for the administrator to figure out what is wrong (or that something is wrong to begin with). If there are any invalid plugins, the Manage Plugins page should detect them and present the administrator with a list, allowing them to fix the problem. | ||||
Tags | No tags attached. | ||||
Consider the following scenario: a MantisBT instance with a successfully installed 3rd party plugin (e.g. Announce).
Contents of plugin directory:
Contents of _mantis_plugintable:
None of these errors are visible on the GUI (except for possibly missing menu items, etc. as the plugins are not registered) as shown on the screenshot below. |
|
PR https://github.com/mantisbt/mantisbt/pull/1565 See attached screenshots showing how the test scenario looks like with the new code, in
Note that if there are no invalid or missing plugins, the section is not displayed. |
|
For the record, here are the 2 dummy invalid plugins I used for testing. |
|
MantisBT: master 11a6d0de 2021-01-16 04:43 Details Diff |
Improve handling of invalid plugins When installing plugins in a MantisBT instance, or when moving / upgrading MantisBT there are several things that can go wrong: - The case of the directory in which the plugin is installed does not exactly match the plugin's name - A registered plugin is no longer present on disk - The plugin code could be invalid - etc. This feature branch adds an "Invalid plugins" section on Manage Plugins page, allowing the Administrator to identify issues and eventually fix them. Fixes 0026142, PR https://github.com/mantisbt/mantisbt/pull/1565 |
Affected Issues 0026142 |
|
add - admin/check/check_plugins_inc.php | Diff File | ||
mod - admin/check/index.php | Diff File | ||
add - core/classes/InvalidDefinitionPlugin.class.php | Diff File | ||
add - core/classes/InvalidPlugin.class.php | Diff File | ||
mod - core/classes/MantisPlugin.class.php | Diff File | ||
add - core/classes/MissingClassPlugin.class.php | Diff File | ||
add - core/classes/MissingPlugin.class.php | Diff File | ||
mod - core/plugin_api.php | Diff File | ||
mod - lang/strings_english.txt | Diff File | ||
mod - manage_plugin_page.php | Diff File | ||
mod - manage_plugin_uninstall.php | Diff File | ||
mod - manage_plugin_upgrade.php | Diff File | ||
MantisBT: master-2.25 54ef8296 2023-04-13 10:31 Details Diff |
Allow installation of plugins without dependencies The refactoring of manage_plugin_page with objects [1] introduced a regression, preventing user from installing plugins without any dependencies (i.e. having 'requires' property null or empty array). Fixes 0032390 [1]: issue 0026142, commit c1076a520e38fb823c61ef540c2cf7da6e58aec2 |
Affected Issues 0026142, 0032390 |
|
mod - manage_plugin_page.php | Diff File |